Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(neon_framework,tool): Add missing server icons #2515

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

provokateurin
Copy link
Member

The script didn't find icons in sub-directories of app imgs and also omitted the top-level core imgs.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.47%. Comparing base (520557a) to head (bd80dc2).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2515   +/-   ##
=======================================
  Coverage   28.47%   28.47%           
=======================================
  Files         352      352           
  Lines      135907   135907           
=======================================
  Hits        38699    38699           
  Misses      97208    97208           
Flag Coverage Δ *Carryforward flag
account_repository 98.76% <ø> (ø)
cookie_store 99.48% <ø> (ø) Carriedforward from 520557a
dashboard_app 96.05% <ø> (ø)
dynamite 31.08% <ø> (ø) Carriedforward from 520557a
dynamite_end_to_end_test 61.69% <ø> (ø) Carriedforward from 520557a
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 520557a
neon_dashboard 96.05% <ø> (ø) Carriedforward from 520557a
neon_framework 57.07% <ø> (ø)
neon_http_client 97.50% <ø> (ø) Carriedforward from 520557a
neon_notifications 100.00% <ø> (ø) Carriedforward from 520557a
neon_talk 99.45% <ø> (ø) Carriedforward from 520557a
nextcloud 24.26% <ø> (ø) Carriedforward from 520557a
notifications_app 100.00% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 520557a
talk_app 99.09% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@provokateurin provokateurin merged commit 8d5783c into main Sep 26, 2024
10 checks passed
@provokateurin provokateurin deleted the fix/neon_framework/missing-server-icons branch September 26, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants